linux-kernel - RE: [PATCH] radix-tree: replace <linux/spinlock.h> with <linux/spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR21MB0845CCE594774EB02CBC256ECB2B0@MWHPR21MB0845.namprd21.prod.outlook.com>
Date:   Mon, 13 Nov 2017 16:09:05 +0000
From:   Matthew Wilcox <mawilcox@...rosoft.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     Jan Kara <jack@...e.cz>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        "Chris Mi" <chrism@...lanox.com>
Subject: RE: [PATCH] radix-tree: replace <linux/spinlock.h> with
 <linux/spinlock_types.h>

It's a waste of time.  I have the XArray replacement well in hand, so this header isn't staying around long-term.

> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@...ionext.com]
> Sent: Sunday, November 12, 2017 11:43 PM
> To: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>; Matthew Wilcox
> <mawilcox@...rosoft.com>; Jan Kara <jack@...e.cz>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; Johannes Weiner <hannes@...xchg.org>;
> Chris Mi <chrism@...lanox.com>
> Subject: Re: [PATCH] radix-tree: replace <linux/spinlock.h> with
> <linux/spinlock_types.h>
> 
> Hi Andrew,
> 
> 
> 2017-10-13 22:03 GMT+09:00 Masahiro Yamada
> <yamada.masahiro@...ionext.com>:
> > This header contains references to spinlock_t and lockdep_is_held(),
> > both of which are defined in <linux/spinlock_types.h>
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> 
> 
> I have not got any comment on this patch.
> 
> Could you take a look at it, please?
> 
> 
> > ---
> >
> >  include/linux/radix-tree.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h
> > index 567ebb5..6df7fa9 100644
> > --- a/include/linux/radix-tree.h
> > +++ b/include/linux/radix-tree.h
> > @@ -27,7 +27,7 @@
> >  #include <linux/list.h>
> >  #include <linux/preempt.h>
> >  #include <linux/rcupdate.h>
> > -#include <linux/spinlock.h>
> > +#include <linux/spinlock_types.h>
> >  #include <linux/types.h>
> >
> >  /*
> > --
> > 2.7.4
> >
> 
> 
> 
> --
> Best Regards
> Masahiro Yamada