linux-kernel - Re: drivers/firmware/google/vpd.c: duplicate sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6634ab5b-b21f-120e-2a29-52c824d5dcff@infradead.org>
Date:   Mon, 13 Nov 2017 10:18:35 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Guenter Roeck <groeck@...omium.org>,
        Wei-Ning Huang <wnhuang@...gle.com>
Subject: Re: drivers/firmware/google/vpd.c: duplicate sysfs file

On 11/13/2017 06:41 AM, Guenter Roeck wrote:
> 
> 
> On Sun, Nov 12, 2017 at 10:36 PM, Randy Dunlap <rdunlap@...radead.org <mailto:rdunlap@...radead.org>> wrote:
> 
>     sysfs: cannot create duplicate filename '/devices/platform/vpd'
> 
>     on the second load of this driver.  I.e.,
> 
>     modprobe vpd-sysfs
>     rmmod vpd-sysfs
>     modprobe vpd-sysfs
>     [boom]
> 
> Neither the platform device nor the platform driver driver are ever unregistered, so this isn't entirely surprising. I'll try to reproduce and send a patch.


Seems to be a common theme:

google> grep --color=never "platform.*register" *.c
coreboot_table-acpi.c:	return platform_driver_register(&coreboot_table_acpi_driver);
coreboot_table-of.c:	return platform_driver_register(&coreboot_table_of_driver);

gsmi.c:	gsmi_dev.pdev = platform_device_register_full(&gsmi_dev_info);
gsmi.c:	platform_device_unregister(gsmi_dev.pdev);
gsmi.c:	platform_device_unregister(gsmi_dev.pdev);
[looks good]

memconsole-coreboot.c:	pdev = platform_device_register_simple("memconsole", -1, NULL, 0);
memconsole-coreboot.c:	platform_driver_register(&memconsole_driver);

vpd.c:	pdev = platform_device_register_simple("vpd", -1, NULL, 0);
vpd.c:	platform_driver_register(&vpd_driver);




-- 
~Randy