linux-kernel - Re: [PATCH v1 3/5] perf, tools, script: Allow printing period for non freq mode groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171113182346.GC4123@kernel.org>
Date:   Mon, 13 Nov 2017 15:23:46 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Andi Kleen <andi@...stfloor.org>, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v1 3/5] perf, tools, script: Allow printing period for
 non freq mode groups

Em Mon, Nov 13, 2017 at 10:11:58AM +0100, Jiri Olsa escreveu:
> On Thu, Nov 09, 2017 at 06:55:26AM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@...ux.intel.com>
> > 
> > When using leader sampling the values of the not sampled but counted
> > events are shown by perf script in "period".
> > 
> > Currently printing period is only allowed when the main event
> > has a period, that is it is in frequency mode.
> > 
> > This implies that we cannot dump the values of counted events
> > when the leader event is not in frequency mode.
> > 
> > Just remove the check that the period must be set on all
> > events. It will just be printed as 0 instead if it's not
> > available.
> 
> it'll be the value of configured period, not 0
> 
> int perf_evsel__parse_sample(struct ...
>   ...
>   data->period = evsel->attr.sample_period;
> 
>   $ perf record -c 100000 
>   $ perf script -F event,period | head -3
>   Failed to open /tmp/perf-2048.map, continuing without symbols
>       100000 cycles:ppp: 
>       100000 cycles:ppp: 
> 
> 
> other than that I think we can remove that check,
> because we will have always sane number in period
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Applied, after adding your comments.

- Arnaldo