linux-kernel - Re: [PATCH 4/7] perf tests: Set evlist of test__basic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171113183146.GD8836@kernel.org>
Date:   Mon, 13 Nov 2017 15:31:46 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wang Nan <wangnan0@...wei.com>
Cc:     linux-kernel@...r.kernel.org, kan.liang@...el.com,
        jolsa@...hat.com, namhyung@...nel.org
Subject: Re: [PATCH 4/7] perf tests: Set evlist of test__basic_mmap() to
 !overwrite

Em Mon, Nov 13, 2017 at 01:38:06AM +0000, Wang Nan escreveu:
> In this test, a large ring buffer is required so all events can feed into,
> so overwrite or not is meaningless.
> 
> Change to !overwrite so following commits can remove this argument.

applied
 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> ---
>  tools/perf/tests/mmap-basic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
> index bc8a70e..667d696 100644
> --- a/tools/perf/tests/mmap-basic.c
> +++ b/tools/perf/tests/mmap-basic.c
> @@ -93,7 +93,7 @@ int test__basic_mmap(struct test *test __maybe_unused, int subtest __maybe_unuse
>  		expected_nr_events[i] = 1 + rand() % 127;
>  	}
>  
> -	if (perf_evlist__mmap(evlist, 128, true) < 0) {
> +	if (perf_evlist__mmap(evlist, 128, false) < 0) {
>  		pr_debug("failed to mmap events: %d (%s)\n", errno,
>  			 str_error_r(errno, sbuf, sizeof(sbuf)));
>  		goto out_delete_evlist;
> -- 
> 2.10.1