| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADnq5_NXqToFOvrTqVAxSi2QuzRJbbSY694+sjfMzPGrAvpBBA@mail.gmail.com>
Date: Mon, 13 Nov 2017 14:21:49 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: "Chen, Horace" <Horace.Chen@....com>
Cc: "Liu, Monk" <Monk.Liu@....com>,
Colin King <colin.king@...onical.com>,
"Deucher, Alexander" <Alexander.Deucher@....com>,
"Koenig, Christian" <Christian.Koenig@....com>,
David Airlie <airlied@...ux.ie>,
"Yu, Xiangliang" <Xiangliang.Yu@....com>,
"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
On Mon, Nov 13, 2017 at 9:40 AM, Chen, Horace <Horace.Chen@....com> wrote:
> Reivewed-by: Horace Chen <horace.chen@....com>
Applied. thanks!
Alex
>
> -----Original Message-----
> From: Liu, Monk
> Sent: Monday, November 13, 2017 11:43 AM
> To: Chen, Horace <Horace.Chen@....com>; Colin King <colin.king@...onical.com>; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; David Airlie <airlied@...ux.ie>; Yu, Xiangliang <Xiangliang.Yu@....com>; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
> Importance: High
>
> + Horace
>
> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: 2017年11月11日 19:51
> To: Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>; David Airlie <airlied@...ux.ie>; Liu, Monk <Monk.Liu@....com>; Yu, Xiangliang <Xiangliang.Yu@....com>; amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] drm/amdgpu/virt: remove redundant variable pf2vf_ver
>
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable pf2vf_ver is assigned but never read, it is redundant and hence can be removed.
>
> Cleans up clang warning:
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:310:3: warning: Value stored to 'pf2vf_ver' is never read
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index 6738df836a70..b1cc179512fa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -296,7 +296,6 @@ int amdgpu_virt_fw_reserve_get_checksum(void *obj,
>
> void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev) {
> - uint32_t pf2vf_ver = 0;
> uint32_t pf2vf_size = 0;
> uint32_t checksum = 0;
> uint32_t checkval;
> @@ -309,7 +308,6 @@ void amdgpu_virt_init_data_exchange(struct amdgpu_device *adev)
> adev->virt.fw_reserve.p_pf2vf =
> (struct amdgim_pf2vf_info_header *)(
> adev->fw_vram_usage.va + AMDGIM_DATAEXCHANGE_OFFSET);
> - pf2vf_ver = adev->virt.fw_reserve.p_pf2vf->version;
> AMDGPU_FW_VRAM_PF2VF_READ(adev, header.size, &pf2vf_size);
> AMDGPU_FW_VRAM_PF2VF_READ(adev, checksum, &checksum);
>
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists