linux-kernel - Re: [PATCH v2] ahci: imx: Handle increased read failures for IMX53 temperature sensor in low frequency mode.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171113201802.GO983427@devbig577.frc2.facebook.com>
Date:   Mon, 13 Nov 2017 12:18:02 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Martyn Welch <martyn.welch@...labora.co.uk>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Egor Starkov <egor.starkov@...com>
Subject: Re: [PATCH v2] ahci: imx: Handle increased read failures for IMX53
 temperature sensor in low frequency mode.

On Mon, Nov 13, 2017 at 10:31:01AM +0000, Martyn Welch wrote:
> From: Egor Starkov <egor.starkov@...com>
> 
> Extended testing has shown that the imx ahci driver sometimes requires
> more than the 100 attempts currently alotted in the driver to perform a
> successful temperature reading when running at minimum (throttled) CPU
> frequency.
> 
> Debugging suggests that the read cycle can take 160 attempts (which given
> that the driver averages 80 readings from the ADC equates to one failure
> on each read).
> 
> Increase the attempt limit to 200 in order to greatly reduce the
> likelihood of the driver failing to perform a temperature reading,
> especially at low CPU frequency.
> 
> Signed-off-by: Egor Starkov <egor.starkov@...com>
> Signed-off-by: Martyn Welch <martyn.welch@...labora.co.uk>

Applied to libata/for-4.15.

Thanks.

-- 
tejun