linux-kernel - Re: [PATCH 4/9] posix-clocks: Enable compat syscalls always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711132159450.2097@nanos>
Date:   Mon, 13 Nov 2017 22:03:42 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Deepa Dinamani <deepa.kernel@...il.com>
cc:     john.stultz@...aro.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, y2038@...ts.linaro.org
Subject: Re: [PATCH 4/9] posix-clocks: Enable compat syscalls always

On Fri, 10 Nov 2017, Deepa Dinamani wrote:
>  
> -#ifdef CONFIG_COMPAT
> -
>  COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
>  		       struct compat_timespec __user *, rmtp)
>  {
> @@ -1574,7 +1572,6 @@ COMPAT_SYSCALL_DEFINE2(nanosleep, struct compat_timespec __user *, rqtp,
>  	current->restart_block.nanosleep.compat_rmtp = rmtp;
>  	return hrtimer_nanosleep(&tu, HRTIMER_MODE_REL, CLOCK_MONOTONIC);
>  }
> -#endif

So if I'm not missing something important this will make the compat syscall
define available even for

CONFIG_X86_64=y
CONFIG_IA32_EMULATION=n
CONFIG_X86_X32=n

which is wrong because in that configuration we don't have any 32bit
executable support. So why would we need a compat syscall in that case?

Thanks,

	tglx