linux-kernel - Re: drivers/firmware/google/vpd.c: duplicate sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19B9CA48-C5CC-4EFD-AE6B-527D56F33249@gmail.com>
Date:   Mon, 13 Nov 2017 14:26:36 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Guenter Roeck <groeck@...gle.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Wei-Ning Huang <wnhuang@...gle.com>
Subject: Re: drivers/firmware/google/vpd.c: duplicate sysfs file

On November 13, 2017 2:24:23 PM PST, Guenter Roeck <groeck@...gle.com> wrote:
>On Mon, Nov 13, 2017 at 2:01 PM, Dmitry Torokhov
><dmitry.torokhov@...il.com> wrote:
>> On Mon, Nov 13, 2017 at 12:14:41PM -0800, Guenter Roeck wrote:
>>> The sysfs warning, yes. However, after unbinding and rebinding the
>>> driver, "cat /sys/firmware/vpd/rw_raw" will result in a crash.
>>>
>>> Sequence:
>>>
>>> echo vpd > /sys/bus/platform/drivers/vpd/unbind
>>> echo vpd > /sys/bus/platform/drivers/vpd/bind # <-- nasty message
>>>
>>> cat /sys/firmware/vpd/rw_raw # <-- crash
>>
>> I'd disable unbind (.suppress_bind_attrs = true) and commented out
>> unload for now. And then looked into fixing properly.
>>
>
>Fixing properly is easy as long as we retain the platform device; I
>already have a set of patches doing just that. I have no idea how to
>implement the non-platform-device variant, if that is what you mean
>with "properly".

Ah, ok then.


Thanks.

-- 
Dmitry