linux-kernel - Re: [RESEND PATCH v2 2/2] sched/deadline: Initialize cp->elements[].cpu to an invalid value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Nov 2017 08:30:54 +0900
From:   Byungchul Park <byungchul.park@....com>
To:     Daniel Bristot de Oliveira <bristot@...hat.com>,
        peterz@...radead.org, mingo@...nel.org, rostedt@...dmis.org
Cc:     linux-kernel@...r.kernel.org, juri.lelli@...il.com,
        kernel-team@....com
Subject: Re: [RESEND PATCH v2 2/2] sched/deadline: Initialize
 cp->elements[].cpu to an invalid value

On 11/13/2017 9:46 PM, Daniel Bristot de Oliveira wrote:
> On 10/12/2017 09:57 AM, Byungchul Park wrote:
>> On Tue, Oct 10, 2017 at 03:44:04PM +0900, Byungchul Park wrote:
>>> Currently, migrating tasks to cpu0 unconditionally happens when the
>>> heap is empty, since cp->elements[].cpu was initialized to 0(=cpu0).
>>> We have to distinguish between the empty case and cpu0 to avoid the
>>> unnecessary migrantions. Therefore, it has to return an invalid value
> 
>     s/migrantions/migrations/ ?
> 
>>> e.i. -1 in that case.
>>
>> This patch does what it should obviously do. Could you check this?
>>
>>> Signed-off-by: Byungchul Park <byungchul.park@....com>
>>> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
>>> ---
>>>   kernel/sched/cpudeadline.c | 10 +++++++++-
>>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
>>> index 9f02035..bcf903f 100644
>>> --- a/kernel/sched/cpudeadline.c
>>> +++ b/kernel/sched/cpudeadline.c
>>> @@ -138,6 +138,12 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
>>>   		int best_cpu = cpudl_maximum_cpu(cp);
>>>   		WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
>>>   
>>> +		/*
>>> +		 * The heap tree is empry for now, just return.
> 
> 		  s/empry/empty/ ?

Hello Daniel,

Thank you very much for pointing out typos.

I shall do spellcheck evetytime submiting patches from now on.

-- 
Thanks,
Byungchul