linux-kernel - Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1711141039400.7290@localhost>
Date:   Tue, 14 Nov 2017 10:41:50 +1100 (AEDT)
From:   James Morris <james.l.morris@...cle.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
cc:     intel-sgx-kernel-dev@...ts.01.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard
 Extensions

On Mon, 13 Nov 2017, Jarkko Sakkinen wrote:

> +
> +	secs_epc = sgx_alloc_page(0);

Use SGX_ALLOC_ATOMIC instead of 0 ?

> +	if (IS_ERR(secs_epc)) {
> +		ret = PTR_ERR(secs_epc);
> +		goto out;
> +	}

> +out:
> +	if (encl)
> +		kref_put(&encl->refcount, sgx_encl_release);
> +	return ret;
> +}

Don't you need an sgx_free_page() somewhere here?



-- 
James Morris
<james.l.morris@...cle.com>