linux-kernel - Re: [PATCH v6 4/5] crash: export paddr_vmcoreinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171114064914.GJ10474@x1>
Date:   Tue, 14 Nov 2017 14:49:14 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Marc-André Lureau <marcandre.lureau@...hat.com>
Cc:     linux-kernel@...r.kernel.org, somlo@....edu, qemu-devel@...gnu.org,
        mst@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
        Dave Young <dyoung@...hat.com>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Tony Luck <tony.luck@...el.com>,
        Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH v6 4/5] crash: export paddr_vmcoreinfo_note()

On 11/13/17 at 08:29pm, Marc-André Lureau wrote:
> The following patch is going to use the symbol from the fw_cfg module,
> to call the function and write the note location details in the
> vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
> 
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Baoquan He <bhe@...hat.com>
> CC: Dave Young <dyoung@...hat.com>
> CC: Dave Young <dyoung@...hat.com>
> CC: Hari Bathini <hbathini@...ux.vnet.ibm.com>
> CC: Tony Luck <tony.luck@...el.com>
> CC: Vivek Goyal <vgoyal@...hat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@...hat.com>
> Acked-by: Gabriel Somlo <somlo@....edu>

ACK

Acked-by: Baoquan He <bhe@...hat.com>

Thanks
Baoquan

> ---
>  kernel/crash_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 6db80fc0810b..47541c891810 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -375,6 +375,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void)
>  {
>  	return __pa(vmcoreinfo_note);
>  }
> +EXPORT_SYMBOL(paddr_vmcoreinfo_note);
>  
>  static int __init crash_save_vmcoreinfo_init(void)
>  {
> -- 
> 2.15.0.125.g8f49766d64
>