linux-kernel - Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASwSgk4wjp-Mn0Ar9vw2oKURtje5gu2uDB4sTHxAAuq_w@mail.gmail.com>
Date:   Tue, 14 Nov 2017 20:13:43 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        cocci@...teme.lip6.fr, Nicolas Palix <nicolas.palix@...g.fr>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck

2017-11-14 20:09 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
>
>
> On Tue, 14 Nov 2017, Masahiro Yamada wrote:
>
>> Hi Julia,
>>
>>
>> 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
>> >> +
>> >> +    # If -j option is given to Make, scripts/coccicheck runs in parallel.
>> >> +    # If coccinelle also runs in parallel, it fails because multiple processes
>> >> +    # try to get access to the same subdirectory that stores stdout/stderr.
>> >> +    # No need to parallelize coccinelle in this case - this mode takes only
>> >> +    # one file input.
>> >> +    NPROC=1
>> >
>> > Since I am also changing Coccinelle to avoid the problem, maybe it would
>> > be better to just remove the explanation sentence (If coccinelle also runs
>> > in parallel,...).
>> >
>> > julia
>>
>> OK.  Which lines are unneeded?
>>
>> Is it OK to remove all the comments, then just add "NPROC=1"?
>
> How about keeping "# No need to parallelize coccinelle in this case - this
> mode takes only one file input."?

Fair enough.

I will send v4 shortly.



> But if you think it is obvious, it would be ok to remove it also.  Someone
> can always do git blame and read the commit message if they have
> questions.
>
> julia
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada