linux-kernel - RE: [PATCH 1/2] ASoC: da7218: fix fix child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337014C1AEB68@SW-EX-MBX01.diasemi.com>
Date:   Tue, 14 Nov 2017 12:02:47 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Johan Hovold <johan@...nel.org>, Mark Brown <broonie@...nel.org>
CC:     Support Opensource <Support.Opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Subject: RE: [PATCH 1/2] ASoC: da7218: fix fix child-node lookup

On 13 November 2017 11:13, Johan Hovold wrote:

> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
> 
> To make things worse, the parent codec node was also prematurely freed.
> 
> Fixes: 4d50934abd22 ("ASoC: da7218: Add da7218 codec driver")
> Cc: stable <stable@...r.kernel.org>     # 4.5
> Cc: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>

> ---
>  sound/soc/codecs/da7218.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
> index b2d42ec1dcd9..56564ce90cb6 100644
> --- a/sound/soc/codecs/da7218.c
> +++ b/sound/soc/codecs/da7218.c
> @@ -2520,7 +2520,7 @@ static struct da7218_pdata *da7218_of_to_pdata(struct
> snd_soc_codec *codec)
>  	}
> 
>  	if (da7218->dev_id == DA7218_DEV_ID) {
> -		hpldet_np = of_find_node_by_name(np, "da7218_hpldet");
> +		hpldet_np = of_get_child_by_name(np, "da7218_hpldet");
>  		if (!hpldet_np)
>  			return pdata;
> 
> --
> 2.15.0