Message-ID: <mhng-aa6949a4-bca4-42f9-98ca-6c3fd8534580@palmer-si-x1c4>
Date:   Tue, 14 Nov 2017 08:00:45 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, patches@...ups.riscv.org,
        Olof Johansson <olof@...om.net>
Subject:     Re: [GIT PULL] RISC-V Port for Linux 4.15 v9

On Tue, 14 Nov 2017 01:04:42 PST (-0800), Arnd Bergmann wrote:
> On Mon, Nov 13, 2017 at 10:56 PM, Palmer Dabbelt <palmer@...belt.com> wrote:
>> The following changes since commit bebc6082da0a9f5d47a1ea2edc099bf671058bd4:
>>
>>   Linux 4.14 (2017-11-12 10:46:13 -0800)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git tags/riscv-for-linus-4.15-arch-v9
>>
>> for you to fetch changes up to 512d88db5ef3de56f392f761657c2ab2cadc0498:
>>
>>   Merge tag 'v4.14' into for-linus (2017-11-13 13:17:51 -0800)
>>
>> ----------------------------------------------------------------
>> RISC-V Port for Linux 4.15 v9
>>
>> This tag contains the core RISC-V Linux port, which has been through
>> nine rounds of review on various mailing lists.  The port is not
>> complete: there's some cleanup patches moving through the review
>> process, a whole bunch of drivers that need some work, and a lot of
>> feature additions that will be needed.
>>
>> The patches contained in this tag have been through nine rounds of
>> review on the various mailing lists.  I have some outstanding cleanup
>> patches, but since there's been so much review on these patches I
>> thought it would be best to submit them as-is and then submit explicit
>> cleanup patches so everyone can review them.  This first patch set is
>> big enough that it's a bit of a pain to constantly rewrite, and it's
>> caused a few headaches with various contributors.
>>
>> The port is definately a work in progress.  While what's there builds
>> and boots with 4.14, it's a bit hard to actually see anything happen
>> because there are no device drivers yet.  I maintain a staging branch
>> that contains all the device drivers and cleanup that actually works,
>> but those patches won't all be ready for a while.  I'd like to get what
>> we currently have into your tree so everyone can start working from a
>> single base -- of particular importance is allowing the glibc
>> upstreaming process to proceed so we can sort out any possibly lingering
>> user-visible ABI problems we might have.
>
> For the contents:
>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Thanks!

>
> As you say, there are a few FIXME's left, but nothing that can't
> just be handled after the merge.
>
> Two small things I noticed about the pull request:
>
> - I see you pulled in the v4.14 tag, presumably to have a cleaner
>   merge base. It's better not to do that kind of "back-merge", it
>   will mess up the git history and it doesn't really help with anything
>   important like bisection through the series.

Oh, sorry.  I wasn't sure what to do.  I've gone ahead and tagged

  riscv-for-linus-4.15-arch-v9-premerge

with my pre-merge commit, in case that's better to merge in.

> - The last commit before the backmerge is from Sep 26. I would
>   assume that you have done other work since then (I saw at
>   least one patch). Shouldn't they be included here?

I guess my thought was to include just the parts that had been fully through
the on-list review process, and then to submit another cleanup pull request
later with all our fixes.  The big chunk of those are going to come from
talking with the glibc people to finalize our ABI, which is easier to do once
we've been merged in.

It's a bit of a chicken and egg problem, so I thought I'd just break the cycle
by getting _something_ in :).

Powered by blists - more mailing lists