linux-kernel - Re: [alsa-devel] [PATCH v3] ASoC: Replace snd_soc_acpi_check_hid with acpi_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0100015fbbf26a1b-15f2d4e5-7c3d-4c15-83f9-1b719ae9a74c-000000@email.amazonses.com>
Date:   Tue, 14 Nov 2017 19:12:27 +0000
From:   Jeremy Cline <jeremy@...ine.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, alsa-devel@...a-project.org,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: Replace snd_soc_acpi_check_hid
 with acpi_dev_present

On Mon, Nov 13, 2017 at 01:43:57PM -0600, Pierre-Louis Bossart wrote:
> On 11/10/2017 12:36 PM, Jeremy Cline wrote:
> > Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
> > and remove the now unused snd_soc_acpi_check_hid function. This should
> > have no functional change.
> 
> The code looks ok, but I'd like to first add the fix for the quirk handling
> regression which appeared in 4.13 and is still there in 4.14. Current fix is
> at https://bugzilla.kernel.org/attachment.cgi?id=258581
> 
> Can we wait a couple of days on this one to avoid mixing bug fixes and
> renames? this would also make the stable branch fix easier to handle.

That makes perfect sense to me. I'm pretty new to all this, should I just
keep an eye on things and rebase this once that patch lands?

Thanks,
Jeremy