linux-kernel - [PATCH 0/1] Use checkpatch.pl to make thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1510701276.9469.19.camel@k3saltt0>
Date:   Tue, 14 Nov 2017 15:14:36 -0800
From:   Simranjit Singh <simranjit.singh@...ebaby.org>
To:     ibm-acpi@....eng.br
Cc:     dvhart@...radead.org, andy@...radead.org,
        ibm-acpi-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 0/1] Use checkpatch.pl to make thinkpad_acpi.c error free:
 octal permissions

From: Simranjit Singh <simranjit.singh@...ebaby.org>

Using the checkpatch.pl script, there were 8 errors in thinkpad_acpi.c. I fixed them by changing permissions to octal,
and by adding parenthesis. 
On the current tree, if you use checkpatch.pl, thinkpad_acpi.c will have 8 errors. With my changes, there are 0 errors.
However, I have added 3 new warnings. 
I'm very new to kernel development, so if I messed up somewhere, please do tell me.
    
Changed binary permissions to octal in accordance with checkpatch.pl in thinkpad_acpi.c

Signed-off-by: Simranjit Singh <simranjit.singh@...ebaby.org>
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 2242d60..9ad1f5b 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -9574,7 +9574,7 @@ static int __init set_ibm_param(const char *val, struct kernel_param *kp)
 MODULE_PARM_DESC(experimental,
 		 "Enables experimental features when non-zero");
 
-module_param_named(debug, dbg_level, uint, 0);
+module_param_named(debug, dbg_level, uint, 0444;
 MODULE_PARM_DESC(debug, "Sets debug level bit-mask");
 
 module_param(force_load, bool, 0444);
@@ -9638,25 +9638,25 @@ static int __init set_ibm_param(const char *val, struct kernel_param *kp)
 #ifdef CONFIG_THINKPAD_ACPI_DEBUGFACILITIES
 module_param(dbg_wlswemul, uint, 0444);
 MODULE_PARM_DESC(dbg_wlswemul, "Enables WLSW emulation");
-module_param_named(wlsw_state, tpacpi_wlsw_emulstate, bool, 0);
+module_param_named(wlsw_state, tpacpi_wlsw_emulstate, 044);
 MODULE_PARM_DESC(wlsw_state,
 		 "Initial state of the emulated WLSW switch");
 
 module_param(dbg_bluetoothemul, uint, 0444);
 MODULE_PARM_DESC(dbg_bluetoothemul, "Enables bluetooth switch emulation");
-module_param_named(bluetooth_state, tpacpi_bluetooth_emulstate, bool, 0);
+module_param_named(bluetooth_state, tpacpi_bluetooth_emulstate, 0444);
 MODULE_PARM_DESC(bluetooth_state,
 		 "Initial state of the emulated bluetooth switch");
 
 module_param(dbg_wwanemul, uint, 0444);
 MODULE_PARM_DESC(dbg_wwanemul, "Enables WWAN switch emulation");
-module_param_named(wwan_state, tpacpi_wwan_emulstate, bool, 0);
+module_param_named(wwan_state, tpacpi_wwan_emulstate, 0444);
 MODULE_PARM_DESC(wwan_state,
 		 "Initial state of the emulated WWAN switch");
 
 module_param(dbg_uwbemul, uint, 0444);
 MODULE_PARM_DESC(dbg_uwbemul, "Enables UWB switch emulation");
-module_param_named(uwb_state, tpacpi_uwb_emulstate, bool, 0);
+module_param_named(uwb_state, tpacpi_uwb_emulstate, 0444);
 MODULE_PARM_DESC(uwb_state,
 		 "Initial state of the emulated UWB switch");
 #endif