linux-kernel - Re: [PATCH] quota: be aware of error from dquot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6bbc1ed-31aa-14b0-7ab5-fcee3d9a4d58@huawei.com>
Date:   Tue, 14 Nov 2017 11:43:49 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jan Kara <jack@...e.cz>
CC:     <jack@...e.com>, <linux-kernel@...r.kernel.org>, <chao@...nel.org>
Subject: Re: [PATCH] quota: be aware of error from dquot_initialize

On 2017/11/13 17:18, Jan Kara wrote:
> On Mon 13-11-17 11:31:48, Chao Yu wrote:
>> Commit 6184fc0b8dd7 ("quota: Propagate error from ->acquire_dquot()")
>> missed to handle error from dquot_initialize in dquot_file_open, fix it.
>>
>> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> 
> Good spotting. I've added the patch to my tree.

Thanks for queuing the patch. :)

BTW, I notice in add_dquot_ref we also didn't handle error of
__dquot_initialize, should we handle it too?

Thanks,

> 
> 								Honza
> 
>> ---
>>  fs/quota/dquot.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
>> index 50b0556a124f..80002c094647 100644
>> --- a/fs/quota/dquot.c
>> +++ b/fs/quota/dquot.c
>> @@ -2133,7 +2133,7 @@ int dquot_file_open(struct inode *inode, struct file *file)
>>  
>>  	error = generic_file_open(inode, file);
>>  	if (!error && (file->f_mode & FMODE_WRITE))
>> -		dquot_initialize(inode);
>> +		error = dquot_initialize(inode);
>>  	return error;
>>  }
>>  EXPORT_SYMBOL(dquot_file_open);
>> -- 
>> 2.15.0.55.gc2ece9dc4de6
>>
>>