linux-kernel - Re: [PATCH] mm: show total hugetlb memory consumption in /proc/meminfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171115224941.GA4286@castle>
Date:   Wed, 15 Nov 2017 22:49:50 +0000
From:   Roman Gushchin <guro@...com>
To:     David Rientjes <rientjes@...gle.com>
CC:     Michal Hocko <mhocko@...nel.org>, <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Dave Hansen <dave.hansen@...el.com>, <kernel-team@...com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: show total hugetlb memory consumption in
 /proc/meminfo

On Wed, Nov 15, 2017 at 02:46:00PM -0800, David Rientjes wrote:
> On Wed, 15 Nov 2017, Michal Hocko wrote:
> 
> > > > >  	if (!hugepages_supported())
> > > > >  		return;
> > > > >  	seq_printf(m,
> > > > > @@ -2987,6 +2989,11 @@ void hugetlb_report_meminfo(struct seq_file *m)
> > > > >  			h->resv_huge_pages,
> > > > >  			h->surplus_huge_pages,
> > > > >  			1UL << (huge_page_order(h) + PAGE_SHIFT - 10));
> > > > > +
> > > > > +	for_each_hstate(h)
> > > > > +		total += (PAGE_SIZE << huge_page_order(h)) * h->nr_huge_pages;
> > > > 
> > > > Please keep the total calculation consistent with what we have there
> > > > already.
> > > > 
> > > 
> > > Yeah, and I'm not sure if your comment eludes to this being racy, but it 
> > > would be better to store the default size for default_hstate during the 
> > > iteration to total the size for all hstates.
> > 
> > I just meant to have the code consistent. I do not prefer one or other
> > option.
> 
> It's always nice when HugePages_Total * Hugepagesize cannot become greater 
> than Hugetlb.  Roman, could you factor something like this into your 
> change accompanied with a documentation upodate as suggested by Dave?

Hi David!

Working on it... I'll post an update soon.

Thanks!