linux-kernel - Re: [PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGSfdShU8PnDPHASREpE7Av0RrMyChv5DyqDeQgALmQjT96JyQ@mail.gmail.com>
Date:   Wed, 15 Nov 2017 08:37:47 +0530
From:   Christina Jacob <christina.jacob.koikara@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Sunil.Goutham@...ium.com,
        Christina Jacob <Christina.Jacob@...ium.com>
Subject: Re: [PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

On Thu, Nov 9, 2017 at 7:08 AM, Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
> On Wed, 08 Nov 2017 10:40:24 +0900 (KST)
> David Miller <davem@...emloft.net> wrote:
>
>> From: Christina Jacob <christina.jacob.koikara@...il.com>
>> Date: Sun,  5 Nov 2017 08:52:30 +0530
>>
>> > From: Christina Jacob <Christina.Jacob@...ium.com>
>> >
>> > Implements port to port forwarding with route table and arp table
>> > lookup for ipv4 packets using bpf_redirect helper function and
>> > lpm_trie  map.
>> >
>> > Signed-off-by: Christina Jacob <Christina.Jacob@...ium.com>
>>
>> Applied to net-next, thank you.
>
> I've not had time to proper test (and review) this V4 patch, but I
> guess I'll have to do so when I get home from Seoul...
>
> I especially want to measure the effect of using bpf_redirect_map().
> To Christina: what performance improvement did you see on your
> board/arch when switching from bpf_redirect() to bpf_redirect_map()?

ndo_xdp_flush is yet to be implemented in our driver.
So I don't see any difference moving from bpf_redirect to bpf_redirect_map.

>
> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer