linux-kernel - RE: [PATCH 4.4 05/56] ARM: dts: imx53-qsb-common: fix FEC pinmux config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3BB206AB2B1BD448954845CE6FF69A8E01CB52F6BA@NT-Mail07.beckhoff.com>
Date:   Wed, 15 Nov 2017 04:03:51 +0000
From:   Patrick Brünn <P.Bruenn@...khoff.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sasha Levin <alexander.levin@...izon.com>,
        "Ben Hutchings" <ben.hutchings@...ethink.co.uk>
Subject: RE: [PATCH 4.4 05/56] ARM: dts: imx53-qsb-common: fix FEC pinmux
 config

>From: Ben Hutchings [mailto:ben.hutchings@...ethink.co.uk]
>Sent: Dienstag, 14. November 2017 16:45
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Patrick Bruenn <p.bruenn@...khoff.com>
>>
>>
>> [ Upstream commit 8b649e426336d7d4800ff9c82858328f4215ba01 ]
>>
>> The pinmux configuration in device tree was different from manual
>> muxing in <u-boot>/board/freescale/mx53loco/mx53loco.c
>> All pins were configured as NO_PAD_CTL(1 << 31), which was fine as the
>> bootloader already did the correct pinmuxing for us.
>> But recently u-boot is migrating to reuse device tree files from the
>> kernel tree, so it seems to be better to have the correct pinmuxing in
>> our files, too.
>[...]
>
>Presumably u-boot will reuse the *upstream* device tree files, which
>implies this doesn't need to be fixed on stable branches.
>
>Ben.
I think Ben made a good point. It might be dangerous to change the pinmux
configuration for an Ethernet controller in  stable kernels, just in case
anyone out there uses a hardware and bootloader with different muxing.
Shawn might be able to tell, if that is even possible.
In case there is at least a chance someone is using a different configuration,
I wouldn't backport this commit to any stable branch.

Regards,
Patrick

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075