linux-kernel - Re: [PATCH] openvswitch: meter: fix NULL pointer dereference in ovs_meter_cmd_reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171115.141849.19410021204989663.davem@davemloft.net>
Date:   Wed, 15 Nov 2017 14:18:49 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     pshelar@...ira.com, netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] openvswitch: meter: fix NULL pointer dereference in
 ovs_meter_cmd_reply_start

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Tue, 14 Nov 2017 14:26:16 -0600

> It seems that the intention of the code is to null check the value
> returned by function genlmsg_put. But the current code is null
> checking the address of the pointer that holds the value returned
> by genlmsg_put.
> 
> Fix this by properly null checking the value returned by function
> genlmsg_put in order to avoid a pontential null pointer dereference.
> 
> Addresses-Coverity-ID: 1461561 ("Dereference before null check")
> Addresses-Coverity-ID: 1461562 ("Dereference null return value")
> Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure")
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Applied.