linux-kernel - Re: [PATCH] memory hotplug: fix comments when add section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171115091855.tkqbex2ow3m5jpdk@dhcp22.suse.cz>
Date:   Wed, 15 Nov 2017 10:18:55 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Fan Du <fan.du@...el.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory hotplug: fix comments when add section

On Wed 15-11-17 16:40:05, Fan Du wrote:
> Here, pfn_to_node should be page_to_nid.
> 
> Signed-off-by: Fan Du <fan.du@...el.com>

Yes, it is a typo. And the one worth fixing because this will make git grep
great again

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  mm/memory_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index d4b5f29..c3c1c57 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
>  	/*
>  	 * Make all the pages reserved so that nobody will stumble over half
>  	 * initialized state.
> -	 * FIXME: We also have to associate it with a node because pfn_to_node
> +	 * FIXME: We also have to associate it with a node because page_to_nid
>  	 * relies on having page with the proper node.
>  	 */
>  	for (i = 0; i < PAGES_PER_SECTION; i++) {
> -- 
> 1.8.3.1

-- 
Michal Hocko
SUSE Labs