linux-kernel - Re: [PATCH 2/2] leds: lm3692x: Introduce LM3692x dual string driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a13eae0-044a-95f1-ab3e-68b2114f623b@ti.com>
Date:   Wed, 15 Nov 2017 07:06:37 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Pavel Machek <pavel@....cz>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>, <rpurdie@...ys.net>,
        <jacek.anaszewski@...il.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-leds@...r.kernel.org>
Subject: Re: [PATCH 2/2] leds: lm3692x: Introduce LM3692x dual string driver

Pavel

On 11/15/2017 07:00 AM, Pavel Machek wrote:
> Hi!
> 
>>>> +	ret = regmap_write(led->regmap, LM3692X_PWM_CTRL,
>>>> +		LM3692X_PWM_FILTER_100 | LM3692X_PWM_SAMP_24MHZ);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming PWM CTRL\n");
>>>> +
>>>> +	ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL,
>>>> +			LM3692X_BRHT_MODE_RAMP_MULTI |
>>>> +			LM3692X_BL_ADJ_POL |
>>>> +			LM3692X_RAMP_RATE_250us);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming BOOST CTRL\n");
>>>> +
>>>> +	ret = regmap_write(led->regmap, LM3692X_AUTO_FREQ_HI, 0x00);
>>>> +	if (ret)
>>>> +		dev_err(&led->client->dev, "Failed programming AUTO HI FREQ\n");
>>>
>>> If something fails, is it wise to continue?
> 
> If something fails, is it wise to continue?
> 

Sorry missed that comment.  It is ok to continue but probably should goto out and return
an error so the probe fails.

Dan

> 									Pavel
> 


-- 
------------------
Dan Murphy