linux-kernel - Re: [PATCH] reiserfs: remove unneeded i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171115132527.GA13707@quack2.suse.cz>
Date:   Wed, 15 Nov 2017 14:25:27 +0100
From:   Jan Kara <jack@...e.cz>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     reiserfs-devel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reiserfs: remove unneeded i_version bump

On Mon 30-10-17 11:20:15, Jeff Layton wrote:
> From: Jeff Layton <jlayton@...hat.com>
> 
> The i_version field in reiserfs is not initialized and is only ever
> updated here. Nothing ever views it, so just remove it.
> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>

Thanks! I've added this patch to my tree.

								Honza

> ---
>  fs/reiserfs/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 5464ec517702..4885c7b6e44f 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -2591,7 +2591,6 @@ static ssize_t reiserfs_quota_write(struct super_block *sb, int type,
>  		return err;
>  	if (inode->i_size < off + len - towrite)
>  		i_size_write(inode, off + len - towrite);
> -	inode->i_version++;
>  	inode->i_mtime = inode->i_ctime = current_time(inode);
>  	mark_inode_dirty(inode);
>  	return len - towrite;
> -- 
> 2.13.6
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR