linux-kernel - Re: [PATCH] btrfs: ref-verify: Remove unused parameter from walk_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Nov 2017 17:36:52 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, Arnd Bergmann <arnd@...db.de>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: ref-verify: Remove unused parameter from
 walk_up_tree() to kill warning

On Wed, Nov 15, 2017 at 04:04:40PM +0100, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
> 
>     fs/btrfs/ref-verify.c: In function ‘btrfs_build_ref_tree’:
>     fs/btrfs/ref-verify.c:1017: warning: ‘root’ is used uninitialized in this function
> 
> The variable is indeed passed uninitialized, but it is never used by the
> callee.  However, not all versions of gcc are smart enough to notice.
> 
> Hence remove the unused parameter from walk_up_tree() to silence the
> compiler warning.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Reviewed-by: David Sterba <dsterba@...e.com>