linux-kernel - Re: [PATCH] PCI/AER: update AER status string print to match other AER logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171115175636.GA1794@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 15 Nov 2017 11:56:36 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Tyler Baicar <tbaicar@...eaurora.org>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI/AER: update AER status string print to match other
 AER logs

Hi Tyler,

On Wed, Nov 15, 2017 at 09:47:41AM -0500, Tyler Baicar wrote:
> On 10/17/2017 11:42 AM, Tyler Baicar wrote:
> >Currently the AER driver uses cper_print_bits() to print the AER status
> >string. This causes the status string to not include the proper PCI device
> >name prefix that the other AER prints include. Also, it has a different
> >print level than all the other AER prints.
> >
> >Update the AER driver to print the AER status string with the proper string
> >prefix and proper print level.
> Hello,
> 
> Will this patch be pulled into 4.15?

Sorry, I am preparing the 4.15 pull request right now, and it doesn't
include this change.

I do like the dev_err() change, but would prefer fewer lines of
output.  I could have applied just the dev_err() change, but to
minimize pain for people who parse the logs, I'd rather make one
change in the output instead of making one change now and another
later.

Bjorn