linux-kernel - Re: [GIT PULL] MD update for 4.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFy5r9cz=28G8G6pjY5mfGFRdwKatPJJ+DULOUvEFsokGw@mail.gmail.com>
Date:   Tue, 14 Nov 2017 16:14:44 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Shaohua Li <shli@...nel.org>, Mike Snitzer <snitzer@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>
Subject: Re: [GIT PULL] MD update for 4.15-rc1

So I've pulled this, but have a question:

On Tue, Nov 14, 2017 at 11:56 AM, Shaohua Li <shli@...nel.org> wrote:
>
> Mike Snitzer (1):
>       md: rename some drivers/md/ files to have an "md-" prefix

is this really sensible? I know I absolutely hate what things like
this does to tab-completion, because everything now has the same
prefix.

And it's not like it adds any value - the "md" is already there in the
directory name.

So honestly, if this was code that I regularly looked at (it isn't),
I'd probably not be happy. As it is, I don't really care all that
much, just wanted to check.

Why is it "md-faulty,c", but "raid5.c", for example?

And if it's to try to separate the "dm-xyz" vs "md-xyz" ones, maybe
making this an actual directory structure rather than a prefix would
be better?

Just throwing this out.

              Linus