linux-kernel - Re: [PATCH] of/pci: Fix theoretical NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171116051027.sirf2g5nai2xpbgy@rob-hp-laptop>
Date:   Wed, 15 Nov 2017 23:10:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of/pci: Fix theoretical NULL dereference

On Wed, Nov 15, 2017 at 12:50:06PM +0000, Robin Murphy wrote:
> In the (relatively mechanical) process of adapting the RID-mapping code
> to put the resulting ID in an output argument rather than the funtion
> return value, we ended up with the debug print using the argument
> pointer rather than the local value, which potentially defeats the
> earlier NULL check.
> 
> Fixes: 987068fcbdb7: "of/irq: Break out msi-map lookup (again)"
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Robin Murphy <robin.murphy@....com>
> ---
>  drivers/of/of_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Rob