linux-kernel - Re: [PATCH] arm: Remove unused __readwrite_bug function

Open Source and information security mailing list archives

Message-ID: <20171116072442.ahrks26g7ojdrwjn@pengutronix.de>
Date:   Thu, 16 Nov 2017 08:24:42 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     linux@...linux.org.uk, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] arm: Remove unused __readwrite_bug function

On Wed, Nov 15, 2017 at 07:33:22PM +0000, Corentin Labbe wrote:
> The function __readwrite_bug() is not used at all, so this patch remove
> it.

This function seems unused since
5621caac1d95 ("ARM: kill off __mem_pci"). Adding Rob as author to Cc.

Best regards
Uwe

> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>  arch/arm/include/asm/io.h | 5 -----
>  arch/arm/kernel/traps.c   | 7 -------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
> index 2cfbc531f63b..6a9d9d2d4c0a 100644
> --- a/arch/arm/include/asm/io.h
> +++ b/arch/arm/include/asm/io.h
> @@ -150,11 +150,6 @@ extern void __iomem * (*arch_ioremap_caller)(phys_addr_t, size_t,
>  extern void (*arch_iounmap)(volatile void __iomem *);
>  
>  /*
> - * Bad read/write accesses...
> - */
> -extern void __readwrite_bug(const char *fn);
> -
> -/*
>   * A typesafe __io() helper
>   */
>  static inline void __iomem *__typesafe_io(unsigned long addr)
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 5cf04888c581..cce8b18d673f 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -757,13 +757,6 @@ baddataabort(int code, unsigned long instr, struct pt_regs *regs)
>  	arm_notify_die("unknown data abort code", regs, &info, instr, 0);
>  }
>  
> -void __readwrite_bug(const char *fn)
> -{
> -	pr_err("%s called, but not implemented\n", fn);
> -	BUG();
> -}
> -EXPORT_SYMBOL(__readwrite_bug);
> -
>  void __pte_error(const char *file, int line, pte_t pte)
>  {
>  	pr_err("%s:%d: bad pte %08llx.\n", file, line, (long long)pte_val(pte));
> -- 
> 2.13.6
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives