linux-kernel - Re: [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711161012510.2191@nanos>
Date:   Thu, 16 Nov 2017 10:15:42 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
cc:     platform-driver-x86@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH v5 09/11] fs/pipe.c: export create_pipe_files() and
 replace_fd()

On Mon, 13 Nov 2017, Jarkko Sakkinen wrote:

+ Cc: Al

- Cc: that intel sgx list because it's moderated and spams my inbox with
      useless moderation mails.

> Exported create_pipe_files() and replace_fd() because the SGX driver
> needs to be able to setup pipes in order to communicate with the helper
> process that hosts the Launch Enclave (LE). The pipe creation will be
> done in the init-callback supplied to call_usermodehelper_setup().
> 
> The driver will use two pipes for communication with the LE hosting
> process:
> 
> * One for writing SIGSTRUCT blobs.
> * One for reading EINITTOKEN blobs.

Can you pretty please make sure that people who maintain the affected code
are CC'd on your changes?

> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> ---
>  fs/file.c | 1 +
>  fs/pipe.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/fs/file.c b/fs/file.c
> index 1fc7fbbb4510..b1fa28919b22 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -871,6 +871,7 @@ int replace_fd(unsigned fd, struct file *file, unsigned flags)
>  	spin_unlock(&files->file_lock);
>  	return err;
>  }
> +EXPORT_SYMBOL_GPL(replace_fd);
>  
>  SYSCALL_DEFINE3(dup3, unsigned int, oldfd, unsigned int, newfd, int, flags)
>  {
> diff --git a/fs/pipe.c b/fs/pipe.c
> index 97e5be897753..ee33a84127e7 100644
> --- a/fs/pipe.c
> +++ b/fs/pipe.c
> @@ -784,6 +784,7 @@ int create_pipe_files(struct file **res, int flags)
>  	iput(inode);
>  	return err;
>  }
> +EXPORT_SYMBOL_GPL(create_pipe_files);
>  
>  static int __do_pipe_flags(int *fd, struct file **files, int flags)
>  {
> -- 
> 2.14.1
> 
>