linux-kernel - Re: [PATCH] Documentation: dt: rtc-imxdi: imx53-rtc is not compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2017 10:44:52 +0100
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     linux-kernel-dev@...khoff.com
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Patrick Bruenn <p.bruenn@...khoff.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Juergen Borleis <jbe@...gutronix.de>,
        Noel Vellemans <Noel.Vellemans@...ionbms.com>,
        Shawn Guo <shawnguo@...nel.org>
Subject: Re: [PATCH] Documentation: dt: rtc-imxdi: imx53-rtc is not compatible

Hi,

The following patch was already sent by Fabio:
http://patchwork.ozlabs.org/patch/838173/

On 16/11/2017 at 10:34:25 +0100, linux-kernel-dev@...khoff.com wrote:
> From: Patrick Bruenn <p.bruenn@...khoff.com>
> 
> rtc-imxdi driver is not compatible with imx53-rtc like the example
> suggested.
> Only the raw timestamp register offsets match by accident, which has the
> effect, that during startup/shutdown system clock syncronization with
> rtc seems to work for imx53, too.
> However hwclock and rtctest, will not work as expected on imx53.
> To avoid future reverts like [1], we should adjust the documentation.
> 
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-November/542312.html
> 
> Signed-off-by: Patrick Bruenn <p.bruenn@...khoff.com>
> 
> ---
> 
> To: Alessandro Zummo <a.zummo@...ertech.it>
> To: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Cc: linux-rtc@...r.kernel.org (open list:REAL TIME CLOCK (RTC) SUBSYSTEM)
> Cc: devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Cc: linux-kernel@...r.kernel.org (open list)
> Cc: Fabio Estevam <fabio.estevam@....com>
> Cc: Juergen Borleis <jbe@...gutronix.de>
> Cc: Noel Vellemans <Noel.Vellemans@...ionbms.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> ---
>  Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> index 323cf26374cb..af853b0ceac5 100644
> --- a/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> +++ b/Documentation/devicetree/bindings/rtc/imxdi-rtc.txt
> @@ -1,6 +1,6 @@
>  * i.MX25 Real Time Clock controller
>  
> -This binding supports the following chips: i.MX25, i.MX53
> +This binding supports the following chips: i.MX25
>  
>  Required properties:
>  - compatible: should be: "fsl,imx25-rtc"
> @@ -14,7 +14,7 @@ Optional properties:
>  Example:
>  
>  rtc@...56000 {
> -	compatible = "fsl,imx53-rtc", "fsl,imx25-rtc";
> +	compatible = "fsl,imx25-rtc";
>  	reg = <0x80056000 2000>;
>  	interrupts = <29 56>;
>  };
> -- 
> 2.11.0
> 
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com