lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMuHMdXcvBDGvQ0K38POmarUY65ntTw5-xh9s=Sk4ZH+98MrhQ@mail.gmail.com> Date: Thu, 16 Nov 2017 12:05:19 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Arnd Bergmann <arnd@...db.de> Cc: Tatyana Nikolova <Tatyana.E.Nikolova@...el.com>, Roland Dreier <roland@...estorage.com>, Doug Ledford <dledford@...hat.com>, linux-rdma <linux-rdma@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH/RFC] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo() Hi Arnd, On Thu, Nov 16, 2017 at 11:50 AM, Arnd Bergmann <arnd@...db.de> wrote: > On Thu, Nov 16, 2017 at 11:26 AM, Geert Uytterhoeven > <geert@...ux-m68k.org> wrote: >> With gcc-4.1.2: >> >> drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: >> drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used uninitialized in this function >> >> Indeed, if nl_client is not found in any of the scanned has buckets, ret >> will be used uninitialized. >> >> Preinitialize ret to zero to fix this. >> >> Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper user space service") >> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org> >> --- >> RFC as I have no idea if this can ever happen, and if yes, what's the >> correct behavior to handle it: >> - return 0, >> - return an error code, >> - don't send anything, >> - anything else? > > This looks like a reasonable warning. I don't see on my box with any compiler > version. Do you have a configuration I can use to reproduce it, I'd just like > to see out of curiosity which other compilers report it. m68k/allmodconfig Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists