linux-kernel - Re: [PATCH] soc/tegra: pmc: fix child-node lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2017 13:40:24 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Johan Hovold <johan@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable <stable@...r.kernel.org>,
        Mikko Perttunen <mperttunen@...dia.com>
Subject: Re: [PATCH] soc/tegra: pmc: fix child-node lookup

On 15.11.2017 11:44, Johan Hovold wrote:
> Fix child-node lookup during probe, which ended up searching the whole
> device tree depth-first starting at the parent rather than just matching
> on its children.
>
> To make things worse, the parent pmc node could end up being prematurely
> freed as of_find_node_by_name() drops a reference to its first argument.
>
> Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC")
> Cc: stable <stable@...r.kernel.org>     # 4.0
> Cc: Mikko Perttunen <mperttunen@...dia.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/soc/tegra/pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index 0453ff6839a7..7e9ef3431bea 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -1321,7 +1321,7 @@ static void tegra_pmc_init_tsense_reset(struct tegra_pmc *pmc)
>  	if (!pmc->soc->has_tsense_reset)
>  		return;
>
> -	np = of_find_node_by_name(pmc->dev->of_node, "i2c-thermtrip");
> +	np = of_get_child_by_name(pmc->dev->of_node, "i2c-thermtrip");
>  	if (!np) {
>  		dev_warn(dev, "i2c-thermtrip node not found, %s.\n", disabled);
>  		return;
>

Good find!

Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>