linux-kernel - RE: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEEC19ED4@MIPSMAIL01.mipstec.com>
Date:   Thu, 16 Nov 2017 12:45:28 +0000
From:   Aleksandar Markovic <Aleksandar.Markovic@...s.com>
To:     James Hogan <James.Hogan@...s.com>,
        Aleksandar Markovic <aleksandar.markovic@...rk.com>
CC:     "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>,
        Miodrag Dinic <Miodrag.Dinic@...s.com>,
        Goran Ferenc <Goran.Ferenc@...s.com>,
        "David S. Miller" <davem@...emloft.net>,
        Douglas Leung <Douglas.Leung@...s.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Paul Burton <Paul.Burton@...s.com>,
        Petar Jovanovic <Petar.Jovanovic@...s.com>,
        Raghu Gandham <Raghu.Gandham@...s.com>,
        "Ralf Baechle" <ralf@...ux-mips.org>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: RE: [PATCH v9 3/3] MIPS: ranchu: Add Ranchu as a new generic-based
 board

> From: James Hogan
> 
> Hi Aleksandar,
> 
> On Wed, Nov 15, 2017 at 02:42:20PM +0100, Aleksandar Markovic wrote:
> > diff --git a/arch/mips/configs/generic/board-ranchu.config b/arch/mips/configs/generic/board-ranchu.config
> > new file mode 100644
> > index 0000000..fee9ad4
> > --- /dev/null
> > +++ b/arch/mips/configs/generic/board-ranchu.config
> > @@ -0,0 +1,30 @@
> > +CONFIG_VIRT_BOARD_RANCHU=y
> 
> I presume its valid for Ranchu support to be enabled in MIPS32 / MIPS64,
> and R1 / R2 / R6 kernels? (that's fine if so, just making sure there's
> no need for a require comment).

Yes, Ranchu virtual machine, and Android emulator for that matter, support
all combinations you mentioned.

> 
> > diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c
> > new file mode 100644
> > index 0000000..0efc555
> > --- /dev/null
> > +++ b/arch/mips/generic/board-ranchu.c
> > @@ -0,0 +1,85 @@
> 
> ...
> 
> > +static __init unsigned int ranchu_measure_hpt_freq(void)
> > +{
> 
> ...
> 
> > +     count += 5000;  /* round */
> > +     count -= count % 10000;
> 
> A comment to explain the purpose of the rounding would be helpful. I
> presume its there just to get a more accurate value since the frequency
> will always be a round value in practice.

An appropriate comment will be added in v10, but v10 will be submitted
no sooner than next week, to provide enough time for other people wanting
to review this and other patches.

> 
> Either way this patch looks good to me:
> Reviewed-by: James Hogan <jhogan@...nel.org>
> 
> Thanks!
> James

I appreciate your review!

Aleksandar