linux-kernel - Re: [PATCH] mm: shmem: remove unused info variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171116131804.o43atl6lizirmx5p@dhcp22.suse.cz>
Date:   Thu, 16 Nov 2017 14:18:04 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     hughd@...gle.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: shmem: remove unused info variable

On Thu 16-11-17 14:17:43, Michal Hocko wrote:
> This seems familiar. Ohh, you have posted it
> http://lkml.kernel.org/r/20171021165032.20542-1-clabbe.montjoie@gmail.com
> already. It fall though cracks, it seems. CCing Andrew 

now, for real

> On Wed 15-11-17 19:27:09, Corentin Labbe wrote:
> > This patch fix the following build warning by simply removing the unused
> > info variable.
> > mm/shmem.c:3205:27: warning: variable 'info' set but not used [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> 
> Acked-by: Michal Hocko <mhocko@...e.com>
> 
> > ---
> >  mm/shmem.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/mm/shmem.c b/mm/shmem.c
> > index 544c105d706a..7fbe67be86fa 100644
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -3202,7 +3202,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> >  	int len;
> >  	struct inode *inode;
> >  	struct page *page;
> > -	struct shmem_inode_info *info;
> >  
> >  	len = strlen(symname) + 1;
> >  	if (len > PAGE_SIZE)
> > @@ -3222,7 +3221,6 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s
> >  		error = 0;
> >  	}
> >  
> > -	info = SHMEM_I(inode);
> >  	inode->i_size = len-1;
> >  	if (len <= SHORT_SYMLINK_LEN) {
> >  		inode->i_link = kmemdup(symname, len, GFP_KERNEL);
> > -- 
> > 2.13.6
> 
> -- 
> Michal Hocko
> SUSE Labs

-- 
Michal Hocko
SUSE Labs