linux-kernel - Re: [PATCH] perf kmem: Change a word from migratetype to migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171116141433.GT8836@kernel.org>
Date:   Thu, 16 Nov 2017 11:14:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Sihyeon Jang <uneedsihyeon@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf kmem: Change a word from migratetype to
 migrate_type for unity

Em Thu, Nov 16, 2017 at 10:41:46PM +0900, Sihyeon Jang escreveu:
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Sihyeon Jang <uneedsihyeon@...il.com>

Please describe the problem and why such word change is warranted.

Its not enough to say what is being done, you need to say _why_.

And this seems bogus, look:

                { "kmem:mm_page_alloc",         perf_evsel__process_page_alloc_event, },

So that function handles:

[root@...et ~]# grep field.*migrate /sys/kernel/debug/tracing/events/kmem/mm_page_alloc/format 
	field:int migratetype;	offset:24;	size:4;	signed:1;
[root@...et ~]# 

The field is not named "migrate_type", so your change will _break_ the
'perf kmem' tool, not good :-)

- Arnaldo

> ---
>  tools/perf/builtin-kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index 557d391..43858cd 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -786,7 +786,7 @@ static int perf_evsel__process_page_alloc_event(struct perf_evsel *evsel,
>  	unsigned int order = perf_evsel__intval(evsel, sample, "order");
>  	unsigned int gfp_flags = perf_evsel__intval(evsel, sample, "gfp_flags");
>  	unsigned int migrate_type = perf_evsel__intval(evsel, sample,
> -						       "migratetype");
> +						       "migrate_type");
>  	u64 bytes = kmem_page_size << order;
>  	u64 callsite;
>  	struct page_stat *pstat;
> -- 
> 2.7.4