linux-kernel - Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171116170443.GE3187@localhost>
Date:   Thu, 16 Nov 2017 22:34:43 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>,
        Takashi <tiwai@...e.de>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH v2 04/14] soundwire: Add MIPI DisCo property helpers

On Thu, Nov 16, 2017 at 04:05:34PM +0000, Srinivas Kandagatla wrote:
> Few Minor comments!!

All are helpful :)

> >+/**
> >+ * enum sdw_clk_stop_mode: Clock Stop modes
> >+ *
> >+ * @SDW_CLK_STOP_MODE_0: Slave can continue operation seamlessly on clock
> >+ * restart
> >+ * @SDW_CLK_STOP_MODE_1: Slave may have entered a deeper power-saving mode,
> Should be MODE0 and MODE1.. here

yes thanks for spotting

> >+/**
> >+ * struct sdw_dpn_audio_mode: Audio mode properties for DPn
> >+ *
> >+ * @bus_min_freq: Minimum bus frequency, in Hz
> >+ * @bus_max_freq: Maximum bus frequency, in Hz
> >+ * @bus_num_freq: Number of discrete frequencies supported
> >+ * @bus_freq: Discrete bus frequencies, in Hz
> >+ * @bus_min_freq: Minimum sampling frequency, in Hz
> Should be min_freq
> >+ * @bus_max_freq: Maximum sampling bus frequency, in Hz
> Should be max_freq
> >+ * @bus_num_freq: Number of discrete sampling frequency supported
> Should be num_freq
> 
> >+ * @bus_freq: Discrete sampling frequencies, in Hz
> Should be freq

yes, will fix

> >+ * @p15_behave: Slave behavior when the Master attempts a read to the Port15
> >+ * alias
> >+ * @lane_control_support:
> 
> ?? do description here..

will add

-- 
~Vinod