linux-kernel - Re: [PATCH] scsi: Use 'blist_flags_t' for scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1a7znqe5l.fsf@oracle.com>
Date:   Wed, 15 Nov 2017 19:07:50 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        James Bottomley <james.bottomley@...senpartnership.com>,
        Christoph Hellwig <hch@....de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-scsi@...r.kernel.org,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags


Hi Hannes,

> As per recommendation from Linus we should be using a distinct
> type for blacklist flags.
> -#define BLIST_MAX_1024		((__force __u32 __bitwise)(1 << 30))
> +#define BLIST_MAX_1024		((__force blist_flags_t)(1 << 30))

You are missing:

/* Use UNMAP limit for WRITE SAME */
#define BLIST_UNMAP_LIMIT_WS		((__force blist_flags_t)(1 << 31))

I'll fix it up...

-- 
Martin K. Petersen	Oracle Linux Engineering