linux-kernel - Re: [PATCH] binder: fix proc->files use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Nov 2017 09:48:13 -0800
From:   Todd Kjos <tkjos@...roid.com>
To:     Todd Kjos <tkjos@...gle.com>, Greg KH <gregkh@...uxfoundation.org>,
        "Arve Hj??nnev??g" <arve@...roid.com>, devel@...verdev.osuosl.org,
        LKML <linux-kernel@...r.kernel.org>,
        Martijn Coenen <maco@...gle.com>
Subject: Re: [PATCH] binder: fix proc->files use-after-free

> @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
>  static void binder_free_proc(struct binder_proc *proc);
>  static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
>
> +struct files_struct *binder_get_files_struct(struct binder_proc *proc)

This should be declared static:
  static struct files_struct *binder_get_files_struct(struct binder_proc *proc)

Greg- should I send a "v2" for this?

> +{
> +       return get_files_struct(proc->tsk);
> +}
> +