linux-kernel - Re: [patch 1/7] Documentation: Add license-rules.rst to describe how to properly identify file licenses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171117085731.GA28421@kroah.com>
Date:   Fri, 17 Nov 2017 09:57:31 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Jonas Oberg <jonas@...e.org>, Jonathan Corbet <corbet@....net>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...uxfoundation.org>,
        Andrew Morton <akpm@...uxfoundation.org>,
        Christoph Hellwig <hch@....de>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Rob Herring <rob.herring@...aro.org>,
        Joe Perches <joe@...ches.com>, xfs <linux-xfs@...r.kernel.org>,
        Kate Stewart <kstewart@...uxfoundation.org>
Subject: Re: [patch 1/7] Documentation: Add license-rules.rst to describe how
 to properly identify file licenses

On Fri, Nov 17, 2017 at 08:37:28AM +0100, Philippe Ombredanne wrote:
> Or fix the non-standard redefinition of the MODULE_LICENSE macro as
> DRIVER_LICENSE as in [2]  and found elsewhere with
> grep -r . -e "DRIVER_LICENSE"
> 
> These break the otherwise nicely grepable MODULE_LICENSE macros
> with this kind of warty redirection I stumbled upon while reviewing kernel
> license scans:
> 
> #define DRIVER_LICENSE "GPL"
> [...]
> MODULE_LICENSE(DRIVER_LICENSE);

Yes, those should be cleaned up, there's only 11 instances of them,
should be simple enough to do.  I can knock up a patch series for
them...

thanks,

greg k-h