linux-kernel - Re: [PATCH] VFS: Handle lazytime in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee6a6760-a0be-c066-2bcb-39ffacafa4c1@suse.de>
Date:   Fri, 17 Nov 2017 06:09:21 -0600
From:   Goldwyn Rodrigues <rgoldwyn@...e.de>
To:     Markus Trippelsdorf <markus@...ppelsdorf.de>,
        Alexander Viro <viro@...iv.linux.org.uk>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Howells <dhowells@...hat.com>,
        Lukas Czerner <lczerner@...hat.com>
Subject: Re: [PATCH] VFS: Handle lazytime in do_mount()



On 10/11/2017 12:01 AM, Markus Trippelsdorf wrote:
> Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") the lazytime mount option doesn't get passed
> on anymore.
> 
> Fix the issue by handling the option in do_mount().
> 
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>

Reviewed-by: Goldwyn Rodrigues <rgoldwyn@...e.com>

> ---
>  fs/namespace.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 54059b142d6b..b633838b8f02 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
>  			    SB_MANDLOCK |
>  			    SB_DIRSYNC |
>  			    SB_SILENT |
> -			    SB_POSIXACL);
> +			    SB_POSIXACL |
> +			    SB_LAZYTIME);
>  
>  	if (flags & MS_REMOUNT)
>  		retval = do_remount(&path, flags, sb_flags, mnt_flags,
> 

-- 
Goldwyn