linux-kernel - Re: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171117123517.jjdia6dwccta5ojp@earth>
Date:   Fri, 17 Nov 2017 13:35:17 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     kishon@...com, tony@...mide.com, robh@...nel.org,
        dan.carpenter@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error
 checking.

Hi,

On Fri, Nov 17, 2017 at 04:55:35PM +0530, Arvind Yadav wrote:
> The platform_get_irq_byname() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq_byname() error
> checking for zero is not correct.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---

Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

-- Sebastian

> changes in v1 : 
>              Patch description was not correct.
>   
>  drivers/phy/motorola/phy-cpcap-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c
> index accaaac..6601ad0 100644
> --- a/drivers/phy/motorola/phy-cpcap-usb.c
> +++ b/drivers/phy/motorola/phy-cpcap-usb.c
> @@ -310,7 +310,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev,
>  	int irq, error;
>  
>  	irq = platform_get_irq_byname(pdev, name);
> -	if (!irq)
> +	if (irq < 0)
>  		return -ENODEV;
>  
>  	error = devm_request_threaded_irq(ddata->dev, irq, NULL,
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)