linux-kernel - Re: [PATCH] of: Document exactly what of_find_node_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLncH8g2bksHMbsO639q649-UQy1DByujywdUL1vH_VXA@mail.gmail.com>
Date:   Fri, 17 Nov 2017 08:08:16 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Frank Rowand <frowand.list@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] of: Document exactly what of_find_node_by_name() puts

On Thu, Nov 16, 2017 at 8:44 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> On 11/10, Randy Dunlap wrote:
>> On 11/10/2017 05:45 PM, Stephen Boyd wrote:
>> > It isn't clear if this function of_node_put()s the 'from'
>> > argument, or the node it finds in the search. Clearly indicate
>> > which variable is touched.
>> >
>> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
>> > ---
>> >  drivers/of/base.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/of/base.c b/drivers/of/base.c
>> > index 63897531cd75..602c5d65734a 100644
>> > --- a/drivers/of/base.c
>> > +++ b/drivers/of/base.c
>> > @@ -866,7 +866,7 @@ EXPORT_SYMBOL(of_find_node_opts_by_path);>   *  @from:  The node to start searching from or NULL, the node
>>
>>     * @from:  The node to start searching from or %NULL; the node
>>
>> >   *         you pass will not be searched, only the next one
>> >   *         will; typically, you pass what the previous call
>>
>>     *         will. Typically, you pass what the previous call
>>
>
> Rob, do you want me to fold this in?

Yes, please.

Rob