linux-kernel - Re: [PATCH] watchdog: pcwd_usb: remove unneeded DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOFm3uEVMKOvyGzO2OxbLxGwYwbhUeTsEu98GopfY=MjMfoWSQ@mail.gmail.com>
Date:   Fri, 17 Nov 2017 15:54:53 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Wim Van Sebroeck <wim@...ana.be>,
        Guenter Roeck <linux@...ck-us.net>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: pcwd_usb: remove unneeded DRIVER_LICENSE #define

On Fri, Nov 17, 2017 at 3:22 PM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when it is defined just a few lines
> above from where it is used.
>
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Reported-by: Philippe Ombredanne <pombredanne@...b.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>


Reviewed-by: Philippe Ombredanne <pombredanne@...b.com>
-- 
Cordially
Philippe Ombredanne