linux-kernel - Re: [alsa-devel] [PATCH v2 03/14] soundwire: Add Master registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171117020604.GG3187@localhost>
Date:   Fri, 17 Nov 2017 07:36:04 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     ALSA <alsa-devel@...a-project.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sudheer Papothi <spapothi@...eaurora.org>,
        Takashi <tiwai@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        plai@...eaurora.org, LKML <linux-kernel@...r.kernel.org>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        patches.audio@...el.com,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Shreyas NC <shreyas.nc@...el.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Sagar Dharia <sdharia@...eaurora.org>, alan@...ux.intel.com
Subject: Re: [alsa-devel] [PATCH v2 03/14] soundwire: Add Master registration

On Thu, Nov 16, 2017 at 05:30:24PM +0000, Mark Brown wrote:
> On Thu, Nov 16, 2017 at 10:19:44PM +0530, Vinod Koul wrote:
> > On Thu, Nov 16, 2017 at 04:05:22PM +0000, Srinivas Kandagatla wrote:
> 
> > > >+	*bus->assigned = ~GENMASK(SDW_BROADCAST_DEV_NUM, SDW_ENUM_DEV_NUM);
> 
> > > Can't we use ida for this.
> > > This would also cut down code added for allocating dev_num.
> 
> > Device numbers in SoundWire are 0 thru 15 with 0 and 15 having special
> > meaning so can'r be allocated. Bitmaps give me a nice way to ensure we dont
> > use those by masking these and above 15... IDR uses bitmap with stuff on top
> > which maynot be helpful here as I need a number 1 to 14. For a generic, give
> > me a number IDRs are very useful.
> 
> Perhaps we need some comments or something explaining the constraints
> here to stop people doing misguided cleanups?

Sure, it is already explained at scattered places, will add this comment here
as well.

-- 
~Vinod