linux-kernel - Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc996517-7d2b-a35a-1a2d-930037668dac@amd.com>
Date:   Fri, 17 Nov 2017 10:45:29 -0500
From:   Harry Wentland <harry.wentland@....com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>
Cc:     dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap
 macro in program_size_and_rotation

On 2017-11-10 05:31 PM, Gustavo A. R. Silva wrote:
> Make use of the swap macro instead of _manually_ swapping values
> and remove unnecessary variable swap.
> 
> This makes the code easier to read and maintain.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28 +++++++---------------
>  1 file changed, 8 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> index a06c602..7bab8c6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
> @@ -237,26 +237,14 @@ static void program_size_and_rotation(
>  	if (rotation == ROTATION_ANGLE_90 ||
>  		rotation == ROTATION_ANGLE_270) {
>  
> -		uint32_t swap;
> -		swap = local_size.video.luma_size.x;
> -		local_size.video.luma_size.x =
> -			local_size.video.luma_size.y;
> -		local_size.video.luma_size.y  = swap;
> -
> -		swap = local_size.video.luma_size.width;
> -		local_size.video.luma_size.width =
> -			local_size.video.luma_size.height;
> -		local_size.video.luma_size.height = swap;
> -
> -		swap = local_size.video.chroma_size.x;
> -		local_size.video.chroma_size.x =
> -			local_size.video.chroma_size.y;
> -		local_size.video.chroma_size.y  = swap;
> -
> -		swap = local_size.video.chroma_size.width;
> -		local_size.video.chroma_size.width =
> -			local_size.video.chroma_size.height;
> -		local_size.video.chroma_size.height = swap;
> +		swap(local_size.video.luma_size.x,
> +		     local_size.video.luma_size.y);
> +		swap(local_size.video.luma_size.width,
> +		     local_size.video.luma_size.height);
> +		swap(local_size.video.chroma_size.x,
> +		     local_size.video.chroma_size.y);
> +		swap(local_size.video.chroma_size.width,
> +		     local_size.video.chroma_size.height);
>  	}
>  
>  	value = 0;
>