linux-kernel - Re: [PATCH] staging: rtl8822be: fix missing null check on dev_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9787e83a-1b4a-cd80-4f2d-bfbe031056db@lwfinger.net>
Date:   Fri, 17 Nov 2017 09:54:01 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Ping-Ke Shih <pkshih@...ltek.com>, devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8822be: fix missing null check on
 dev_alloc_skb return

On 11/17/2017 08:50 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> dev_alloc_skb can potentially return NULL, so add a null check to
> avoid a null pointer dereference on skb

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> 
> Detected by CoverityScan, CID#1454558 ("Dereference on null return")
> 
> Fixes: 7e5b796cde7e ("staging: r8822be: Add the driver code")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c
> index f45487122517..483ea85943c3 100644
> --- a/drivers/staging/rtlwifi/rtl8822be/fw.c
> +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
> @@ -464,6 +464,8 @@ bool rtl8822b_halmac_cb_write_data_rsvd_page(struct rtl_priv *rtlpriv, u8 *buf,
>   	int count;
>   
>   	skb = dev_alloc_skb(size);
> +	if (!skb)
> +		return false;
>   	memcpy((u8 *)skb_put(skb, size), buf, size);
>   
>   	if (!_rtl8822be_send_bcn_or_cmd_packet(rtlpriv->hw, skb, BEACON_QUEUE))
>