linux-kernel - Re: [PATCH] video: fbdev: sm501fb: fix potential null pointer dereference on fbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 17:03:36 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: sm501fb: fix potential null pointer
 dereference on fbi

On Friday, November 10, 2017 05:32:31 PM Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer fbi is dereferenced with par = fbi->par before there is a
> null check on fbi, hence there is a potential null pointer dereference
> on a null par.  Fix this by moving the dereference after the null
> pointer check.
> 
> Detected by CoverityScan, CID#1461301 ("Dereference before null check")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics