linux-kernel - Re: [GIT PULL] usercopy whitelisting for v4.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Nov 2017 18:45:57 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>
Cc:     David Windsor <dave@...lcore.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] usercopy whitelisting for v4.15-rc1

On 17/11/2017 18:35, Linus Torvalds wrote:
> Honestly, I'm unlikely to pull this at all this merge window, simply
> because I won't have time for it. This merge window is not going to be
> one where I can take a leisurely look at something like this.
> 
> If you can make a smaller pull request that introduces the
> infrastructure, but that _obviously_ cannot actually break anything,
> that would be more likely to be palatable.

As someone that was actually bitten by this stuff, and had a closer look
at the usercopy whitelisting stuff...  This one is really fail-fast
(oopses all around if you forget to patch something), and with hardly
any configuration dependency.  It's certainly a lot less scary to me
than the GCC plugin stuff.

But I don't want to ruin your Thanksgiving, so if Kees and/or you choose
not to do this pull request---please do pull a subset, even after -rc1.
It's easy enough to drop the final patch that changes whitelisting to
blacklisting, and it'd be one less series bouncing around and touching
files in several subsystems.

My 2 cents,

Paolo