linux-kernel - Re: [PATCH v2] mm: filemap: remove include of hardirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43348133-9c30-4c4f-8bc9-498841a01bd6@alibaba-inc.com>
Date:   Sat, 18 Nov 2017 01:58:15 +0800
From:   "Yang Shi" <yang.s@...baba-inc.com>
To:     mhocko@...nel.org, akpm@...ux-foundation.org, willy@...radead.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: filemap: remove include of hardirq.h

Hi folks,

Any comment on this patch? The quick build test passed on the latest 
Linus's tree.

Thanks,
Yang


On 11/6/17 8:21 AM, Yang Shi wrote:
> in_atomic() has been moved to include/linux/preempt.h, and the filemap.c
> doesn't use in_atomic() directly at all, so it sounds unnecessary to
> include hardirq.h.
> 
> Signed-off-by: Yang Shi <yang.s@...baba-inc.com>
> ---
> v1 --> v2:
> * Removed the wrong message about kernel size change
> 
>   mm/filemap.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 594d73f..57238f4 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -31,7 +31,6 @@
>   #include <linux/blkdev.h>
>   #include <linux/security.h>
>   #include <linux/cpuset.h>
> -#include <linux/hardirq.h> /* for BUG_ON(!in_atomic()) only */
>   #include <linux/hugetlb.h>
>   #include <linux/memcontrol.h>
>   #include <linux/cleancache.h>
>